NPC Name Color

[SpiffyMeister]

Gumba did the change, I imagine it has something to do with the onspawn quest giver script?

[TheMinionOfArabel]

Might be its a variable on the NPC? We had issue in the past with quest NPCs still showing blue.

[Echo]

qs_giver_spawn (OnSpawn script for quest giver NPCs)
Line 42

SetName(OBJECT_SELF, StringToRGBString(GetName(OBJECT_SELF), "720"));

Change 720 to like.. 760 to make it a bright yellow color

---

For Merchants a new OnSpawn script will need to be written with 777 (white) or 070 (green) or whatever other color we want to use.

[SpiffyMeister]

Done

[Seter]

🥳🥳🥳

[Echo]

v7225 merchants will have a unique color (I probably missed some so you can report any of them here, I guess)

[Echo]

Areas done:

Arabel
Tilverton
Collinwood
Irondrake
Immersea
High Crimmond

[Seter]

Missing in Bospir: Interiors

• Arianne Silverleaf
• Catha Undt

[Zool]

@echo said in NPC Name Color:

v7225 merchants will have a unique color (I probably missed some so you can report any of them here, I guess)

If it's -all- merchants being one particular colour, surely we could detect that they are a merchant in some way (there will be some universal thing about all merchants that doesn't apply to other NPCs that a script can detect) and apply this colour manually.

Surely?

Then there's no need for reports and modifications to keep this maintained, just happens on its own.

Someone..... should look into that.

[SpiffyMeister]

@zool don’t all merchants have the “open store” script…?

[Strife and Discord]

@spiffymeister they do but you then rely on a player making the first action.
How would a player know a merchant is a merchant to interact with them?

[Puffy]

Why not use the merchant faction for a on spawn function

[SpiffyMeister]

@puffy some merchants are set to independent

[Zool]

@strife-and-discord said in NPC Name Color:

@spiffymeister they do but you then rely on a player making the first action.
How would a player know a merchant is a merchant to interact with them?

Check the script on spawn. You can get scripts.

[Gumba]

Try using https://nwnlexicon.com/index.php?title=GetStoreGold on the on spawn script.

If it has no store it returns a -2, if it returns -1 or anything above, means it is a store npc, so you can apply the merchant color, allegedly.

Cheers

[Zool]

@gumba said in NPC Name Color:

Try using https://nwnlexicon.com/index.php?title=GetStoreGold on the on spawn script.

If it has no store it returns a -2, if it returns -1 or anything above, means it is a store npc, so you can apply the merchant color, allegedly.

Cheers

[Strife and Discord]

GetStoreGold() works on the store object and not on the NPC itself.
NWN keeps those two separate, so I dont think it would work.

Its better to work in consolidating all possible spawn scripts of NPCs into a single one.

[Zool]

@strife-and-discord said in NPC Name Color:

GetStoreGold() works on the store object and not on the NPC itself.
NWN keeps those two separate, so I dont think it would work.

Its better to work in consolidating all possible spawn scripts of NPCs into a single one.

They should all use it already to open the store. (could also search for the store object using the universally used variable the convo uses to find it and use GetStoreGold() but... seems over the top. There's a few ways I think, just gotta choose one.

[Echo]

@zool said in NPC Name Color:

If it's -all- merchants being one particular colour, surely we could detect that they are a merchant in some way (there will be some universal thing about all merchants that doesn't apply to other NPCs that a script can detect) and apply this colour manually.

I tried this with the "if it has sMyShop variable" then change color of name, but that broke the dye merchants. They didnt have a sMyShop variable so I added it then they broke.

@Strife-and-Discord and I discussed a rework of the generic OnSpawn script for NPCs to put all these special bits in one place.

[Zool]

@echo said in NPC Name Color:

@zool said in NPC Name Color:

If it's -all- merchants being one particular colour, surely we could detect that they are a merchant in some way (there will be some universal thing about all merchants that doesn't apply to other NPCs that a script can detect) and apply this colour manually.

I tried this with the "if it has sMyShop variable" then change color of name, but that broke the dye merchants. They didnt have a sMyShop variable so I added it then they broke.

@Strife-and-Discord and I discussed a rework of the generic OnSpawn script for NPCs to put all these special bits in one place.

Probly need to check for one, then the other, and potentially follow whatever method they use to find their store to find it then check it's valid and stuff.

I ain't got time right now so I'll shut up now, but it seems pretty plausible.