Using the last charge on a Healing Kit stack consumes a completely unrelated stack

jalafoon

So I have several stacks of Healing Kit +10s.
These are the version with 5 charges each.

Using the last charge off one of the stacks of healing kits seems to consume a completely different kit.
Leaving me with a missing stack of healing kit +10. And a stack that has 0 charges left

Mr.Moloch

@jalafoon Currently, this is a required feature while I hunt down and fix a bug and work through an update to healing kits.

To avoid it, put the kit you're using in the first slot of your inventory for now. When there's lag, I think its just not catching the most recent kit and then destroys the first one it finds.

(Hopefully)

Zool

@Mr-Moloch Nah, the code is just real old, and bad, and just cycles through the entire inventory looking for items tagged with the healing kit stuff, or with a variable, I dont remember, instead of just.... using the item that was used. I forget why, maybe tag suffixing was used to figure out the healing effect, and so tag based scripting couldn't be used as normal or something?

Mr.Moloch

@Zool It does look for the last item used, it doesn't always find it though. Its ridiculous.

Zool

@Mr-Moloch said in Using the last charge on a Healing Kit stack consumes a completely unrelated stack:

@Zool It does look for the last item used, it doesn't always find it though. Its ridiculous.

Should be fixed.

(It didn't look for the same item used - it passed that in, then used it's tag to search the entire inventory for similar items, and deleted one of those if it had 0 charges - I've changed the relevant code to use a tagged effect, rather than a variable to check if the kit is still in effect, as delay command on destroyed objects wont fire, so the variable may never get deleted- likely the cause of the decades long "healing kit bug")

Honestly, it'd a bit of a miracle ths thing has worked as well as it has for the years it's been around.

Hopefully, my fix just works as I didn't get time to test it.... I guess we test in production like true heroes.

jalafoon

Ive confirmed that I used the last charge of a healing kit and it has consumed THAT healing kit